1. 19 Feb, 2020 3 commits
    • Johan Bockgård's avatar
      Fix search for ~/.Xdefaults-HOSTNAME (again) · 4b118bdc
      Johan Bockgård authored
      * src/xrdb.c (get_environ_db): Fix typo when handling
      ~/.Xdefaults-HOSTNAME.
      4b118bdc
    • Masahiro Nakamura's avatar
      Fix working text related issues on NS (Bug#38851) · b3de1302
      Masahiro Nakamura authored
      * src/keyboard.c (read_char): Prevent redsiplay right after
      ns-unput-working-text event.
      * src/nsterm.m ([EmacsView insertText:]): Partially revert commit
      ba042176.
      ([EmacsView firstRectForCharacterRange:]): Fix candidate window
      position when cursor is on echoarea.
      ([EmacsView mouseDown:])
      ([EmacsView windowDidResignKey:]): Don't delete working text.
      b3de1302
    • Alan Third's avatar
      Fix horizontal bit shifting · 1a75e8b7
      Alan Third authored
      * src/nsterm.m ([EmacsView copyRect:to:]): Calculate the horizontal
      difference instead of just the vertical.
      ([EmacsView updateLayer]): Fix NSTRACE message.
      1a75e8b7
  2. 17 Feb, 2020 1 commit
    • Paul Eggert's avatar
      Avoid unlikely load-average bug · 121f9bb1
      Paul Eggert authored
      * src/fns.c (Fload_average): Do not crash or return nonsense
      if the load average exceeds most-positive-fixnum/100 (Bug#39577).
      121f9bb1
  3. 16 Feb, 2020 3 commits
  4. 15 Feb, 2020 1 commit
    • Paul Eggert's avatar
      Fix C-h C-h bug due to mutating a hash key · 3480071d
      Paul Eggert authored
      Problem reported by Federico Tedin (Bug#39529).
      The problem was that dumping uses a hash table based on 'equal'
      when purecopying compiled objects, but then modifies the compiled
      objects while they are keys in the table.  This no-no was uncovered
      by the sxhash fixes in 2020-01-07T19:23:11Z!eggert@cs.ucla.edu.
      Eli Zaretski pinpointed the patch that triggered the bug.
      * src/lread.c (read1): When reading a compiled object, replace
      its docstring with a unique negative integer instead of with 0,
      so that purecopy doesn’t unify it with some other compiled object
      that happens to have the same Lisp code.
      3480071d
  5. 14 Feb, 2020 2 commits
    • Mark Oteiza's avatar
      Fix typos · 3843721c
      Mark Oteiza authored
      * src/lcms.c (lcms-xyz->jch, lcms-jch->xyz): Swap first line of docstrings.
      3843721c
    • Stefan Monnier's avatar
      * src/lread.c: Remove old-style backquotes support · 2e81e573
      Stefan Monnier authored
      (new_backquote_flag): Delete variable.
      (load_error_old_style_backquotes): Delete function.
      (force_new_style_backquotes): Delete variable.
      (read_internal_start): Don't obey it any more.
      2e81e573
  6. 13 Feb, 2020 3 commits
    • Philipp Stephani's avatar
      75a9eee8
    • Alan Mackenzie's avatar
      Make after-change-functions called from call-process get the correct BEG · d1e8ce8b
      Alan Mackenzie authored
      This fixes bug #39585.
      
      * src/callproc.c (call_process): Supply the correct CHARPOS to
      signal_after_change (twice).
      d1e8ce8b
    • Alan Third's avatar
      Use CGImage instead of NSBitmapImageRep (bug#32932) · 44298ea6
      Alan Third authored
      * src/nsterm.m (ns_update_end):
      (ns_clear_frame): Remove forced draws.
      (ns_draw_fringe_bitmap):
      (ns_dumpglyphs_image): No longer need to invert images as the context
      is already flipped.
      ([EmacsView updateFrameSize:]):
      ([EmacsView initFrameFromEmacs:]): Use new function.
      ([EmacsView createDrawingBuffer]): Replaces createDrawingBufferWithRect:.
      ([EmacsView focusOnDrawingBuffer]): Set CGImage context.
      ([EmacsView windowDidChangeBackingProperties:]): Use new function.
      ([EmacsView copyRect:to:]): Copy using CGImages.
      ([EmacsView wantsUpdateLayer]):
      ([EmacsView updateLayer]): New Functions.
      ([EmacsView drawRect:]): We no longer do anything special here for
      Cocoa.
      ([EmacsView windowDidChangeBackingProperties:]): Fix indentation and
      add NSTRACE.
      44298ea6
  7. 11 Feb, 2020 1 commit
  8. 09 Feb, 2020 2 commits
    • Eli Zaretskii's avatar
      Fix set-fontset-font with ADD arg non-nil · 06c302d4
      Eli Zaretskii authored
      * src/fontset.c (fontset_add): Fix off-by-one error at TO.
      (Bug#39482)
      06c302d4
    • Alan Mackenzie's avatar
      Correct "different than" to "different from" where appropriate · 53006746
      Alan Mackenzie authored
      (doc/emacs/screen.texi)
      (doc/lispintro/emacs-lisp-intro.texi)
      (doc/misc/calc.texi)
      (doc/misc/gnus.texi)
      (doc/misc/sc.texi)
      (lisp/align.el)
      (lisp/allout-widgets.el)
      (lisp/allout.el)
      (lisp/emacs-lisp/gv.el)
      (lisp/font-lock.el)
      (lisp/gnus/mm-util.el)
      (lisp/mail/feedmail.el)
      (lisp/mail/sendmail.el)
      (lisp/mail/supercite.el)
      (lisp/org/org-attach.el)
      (lisp/progmodes/cc-langs.el)
      (lisp/progmodes/idlw-shell.el)
      (lisp/ps-print.el)
      (lisp/simple.el)
      (src/cmds.c)
      (src/editfns.c)
      (src/frame.h)
      (src/regex-emacs.c)
      (src/xfaces.c): Replace "different than" by "different from".
      53006746
  9. 08 Feb, 2020 1 commit
  10. 07 Feb, 2020 2 commits
    • Eli Zaretskii's avatar
      Minor fixes of the last commit · ac6ba689
      Eli Zaretskii authored
      * src/xdisp.c (get_window_cursor_type): Fix indentation and
      line-filling.
      * doc/lispref/frames.texi (Cursor Parameters):
      * doc/emacs/display.texi (Cursor Display):
      * etc/NEWS: Fix wording and capitalization of the last change.
      ac6ba689
    • Zajcev Evgeny's avatar
      Support for (box . SIZE) 'cursor-type' · 63fd6c9e
      Zajcev Evgeny authored
      This allows control of the minimum size of a masked image under
      which the box cursor becomes hollow.
      * buffer.c (cursor-type): Add commentary about (box . SIZE)
      'cursor-type'.
      * xdisp.c (get_specified_cursor_type): Check for 'cursor-type'
      of the form (box . SIZE).
      (get_window_cursor_type): Check masked image size for
      (box . SIZE) 'cursor-type'.
      
      * doc/emacs/display.texi (Cursor Display):
      * doc/emacs/display.texi (Cursor Parameters): Add description
      of (box . SIZE) 'cursor-type'.
      
      * etc/NEWS: Mention the new (box . SIZE) 'cursor-type'.
      63fd6c9e
  11. 03 Feb, 2020 1 commit
    • Robert Pluim's avatar
      Cater for 3-argument version of pthread_setname_np · 83150842
      Robert Pluim authored
      Fixes Bug#39363.
      
      * configure.ac: Add check for 3-argument version of
      pthread_setname_np.
      * src/systhread.c (sys_thread_set_name)
      [HAVE_PTHREAD_SETNAME_NP_3ARG]: Call pthread_setname_np with
      3 arguments.
      83150842
  12. 31 Jan, 2020 1 commit
  13. 28 Jan, 2020 1 commit
    • Paul Eggert's avatar
      Revert the --with-install-srcdir patch · a02b1792
      Paul Eggert authored
      Also, update description of debuginfo and sources to match
      Debian and Red Hat more accurately, and move this sad tale
      from INSTALL to etc/PROBLEMS which is a better home for it.
      * Makefile.in (emacs_srcdir, install-c-src):
      * configure.ac (emacs_srcdir, --with-install-srcdir):
      * src/epaths.in (PATH_EMACS_SOURCE):
      * src/lread.c (emacs-source-directory):
      Remove.  All uses removed.
      * lisp/emacs-lisp/find-func.el (find-function-C-source):
      Do not worry about compressed C sources.
      * src/lread.c: Do not include <dosname.h>.
      a02b1792
  14. 27 Jan, 2020 1 commit
  15. 26 Jan, 2020 4 commits
    • Paul Eggert's avatar
      * src/mini-gmp.c: Fix comment typos. · 23ef804e
      Paul Eggert authored
      23ef804e
    • Paul Eggert's avatar
      Update mini-gmp · 901f58ce
      Paul Eggert authored
      * src/mini-gmp.c, src/mini-gmp.h: Copy from GMP 6.2.0.
      This incorporates:
      2019-12-05 remove some sizeof(mp_limb_t)
      2019-12-04 (mpn_invert_3by2): Remove special code for limb sizes
      2019-12-04 (mpn_invert_3by2): Limit size of an intermediate
      2019-11-20 (mpn_invert_3by2): Use xor instead of negation
      2019-11-19 (mpn_invert_3by2): Move an assert earlier
      2019-11-19 (mpn_invert_3by2): Add a new shortcut
      2019-11-17 Prepend "unsigned" to MINI_GMP_LIMB_TYPE
      2019-11-17 Enable testing with different limb sizes (types)
      2019-11-20 Use already defined constants
      2019-11-09 Avoid undefined behaviour with small limb sizes
      901f58ce
    • Mattias Engdegård's avatar
      Correct regexp for flags in `format' doc string · c8fcabf2
      Mattias Engdegård authored
      * src/editfns.c (Fformat): Use the correct regexp for describing the
      flags in a %-sequence (place the hyphen last).
      c8fcabf2
    • Paul Eggert's avatar
      Propagate NSLocale into Emacs better · 26d890c9
      Paul Eggert authored
      * src/emacs.c (main): Call ns_init_locale before using the
      environment variable that ns_init_locale sets up (Bug#39248).
      26d890c9
  16. 25 Jan, 2020 1 commit
    • Paul Eggert's avatar
      Install C source code for C-h f etc. · f42d57c7
      Paul Eggert authored
      Without this change, on typical GNU/Linux distributions
      like Debian, the first button of ‘C-h f car RET’ does not work
      because the source code for ‘car’ is not installed (Bug#37527).
      Fix this by installing the (compressed) C source code alongside
      the (compressed) Lisp source code that is already installed.
      This adds about 3 MB (about 2%) to the size of the installed files
      on my platform.
      * Makefile.in (emacs_srcdir): New macro.
      (epaths-force): Substitute PATH_EMACS_SOURCE.
      (install-c-src): New rule, that installs a copy of the C source
      code if emacs_srcdir says to.
      (install-arch-indep): Depend on it.
      * configure.ac (emacs_srcdir): New var.
      Add support for --disable-install-srcdir.
      * lisp/emacs-lisp/find-func.el (find-function-C-source-directory):
      Look in emacs-source-directory first.
      (find-function-C-source): Also look for gzipped source files.
      * lisp/startup.el (normal-top-level):
      Also recode emacs-source-directory.
      * src/epaths.in (PATH_EMACS_SOURCE): New macro.
      * src/lread.c: Include dosname.h, for IS_ABSOLUTE_FILE_NAME.
      (syms_of_lread): New var emacs-source-directory.
      f42d57c7
  17. 24 Jan, 2020 6 commits
    • Alan Third's avatar
      Draw to offscreen buffer on macOS · f674c905
      Alan Third authored
      * src/nsfns.m (x_set_background_color): Clear the frame after changing
      the background color, not before.
      * src/nsterm.h (drawingBuffer): New variable.
      ([EmacsView focusOnDrawingBuffer]):
      ([EmacsView copyRect:to:]):
      ([EmacsView createDrawingBufferWithRect:]): New methods.
      * src/nsterm.m (ns_update_begin):
      (ns_update_end):
      (ns_focus):
      (ns_unfocus): Handle drawing to offscreen buffer.
      (ns_clip_to_row): Use ns_row_rect.
      (ns_copy_bits): Remove unused function.
      (ns_scroll_run):
      (ns_shift_glyphs_for_insert): Use new scrolling method.
      (ns_draw_fringe_bitmap):
      (ns_dumpglyphs_image): When drawing to the offscreen buffer, flip
      images so they appear the right way up.
      (ns_dumpglyphs_stretch): Remove unnecessary code.
      (ns_draw_window_cursor): Don't disable screen updates.
      ([EmacsView updateFrameSize:]): Update the size of the offscreen
      buffer.
      ([EmacsView initFrameFromEmacs:]): Create offscreen buffer.
      ([EmacsView windowDidChangeBackingProperties:]):
      ([EmacsView createDrawingBufferWithRect:]):
      ([EmacsView focusOnDrawingBuffer]):
      ([EmacsView copyRect]): New methods.
      ([EmacsView viewWillDraw]): Remove method as it no longer does
      anything useful.
      ([EmacsView drawRect:]): Handle drawing from offscreen buffer.
      f674c905
    • Alan Third's avatar
      Revert "Make all NS drawing be done from drawRect" · 3ad78132
      Alan Third authored
      This reverts commit 79464459.
      3ad78132
    • Alan Third's avatar
      Revert "Ensure NS frame is redrawn correctly after scroll" · 6b955c26
      Alan Third authored
      This reverts commit a6ab8db3.
      6b955c26
    • Alan Third's avatar
      Revert "Fix some NS drawing issues (bug#32932)" · ac6e620a
      Alan Third authored
      This reverts commit 7e8eee60.
      ac6e620a
    • Alan Third's avatar
      0bed550e
    • Paul Eggert's avatar
      Simplify locale setup · 75c1f936
      Paul Eggert authored
      Stop exporting Vprevious_system_time_locale and
      Vprevious_system_messages_locale to Elisp.  I did that export by
      mistake in 1999, and the Elisp variables have never been used.
      Simplifying this cruft should make it easier to fix Bug#39248.
      * etc/NEWS: Mention this.
      * src/emacs.c (main): Simplify locale initialization.
      (synchronize_locale): Simplify.
      (Vprevious_system_time_locale, Vprevious_system_messages_locale):
      Now static variables not visible to Lisp, and defined only if
      HAVE_SETLOCALE.
      (Vprevious_system_messages_locale): Define only if LC_MESSAGES.
      75c1f936
  18. 23 Jan, 2020 1 commit
    • Paul Eggert's avatar
      Fix crash when sending Gnus message (Bug#39207) · 6f580542
      Paul Eggert authored
      * src/alloc.c (resize_string_data): The string must be multibyte.
      When not bothering to reallocate, do bother to change the byte count.
      * test/src/alloc-tests.el (aset-nbytes-change) New test.
      6f580542
  19. 22 Jan, 2020 2 commits
    • Alan Mackenzie's avatar
      Make call_process call signal_after_change. This fixes bug #38691. · 224e8d14
      Alan Mackenzie authored
      Now, functions such as call-proess-region invoke after-change-functions
      correctly.
      
      * src/callproc.c (call_process): Call prepare_to_modify_buffer in a single
      place, no longer delegating the task to insert_1_both, etc.  Call
      signal_after_change in each of two code branches, such that
      before-change-functions and after-change-functions are always called in
      balanced pairs.
      224e8d14
    • Eli Zaretskii's avatar
      Fix a few typos · 196c42b8
      Eli Zaretskii authored
      * etc/NEWS: Fix a typo.
      
      * src/xdisp.c (try_window_reusing_current_matrix, try_window_id):
      * src/dispnew.c (scrolling_window): Fix typos in comments.
      196c42b8
  20. 21 Jan, 2020 1 commit
    • Eli Zaretskii's avatar
      Avoid leaving artifacts when the system caret is used on w32 · 4aec94da
      Eli Zaretskii authored
      * src/xdisp.c (try_window_reusing_current_matrix, try_window_id):
      * src/dispnew.c (scrolling_window) [HAVE_NTGUI]: If
      w32-use-visible-system-caret is non-nil, disallow scrolling the
      display are in scroll_run_hook.  This avoids copying traces of the
      caret, about which Emacs knows nothing, and thus considers those
      pixels show the default background.  (Bug#39188)
      (gui_update_window_end): Block input only around part of the code,
      as we did before this code was extracted from backend-specific
      implementations.
      
      * src/w32term.c (w32_update_window_begin, w32_update_window_end):
      Only hide/show the caret when redisplaying the window where the
      caret is shown.
      4aec94da
  21. 20 Jan, 2020 2 commits