1. 01 Jan, 2020 1 commit
  2. 09 Jul, 2019 1 commit
    • Paul Eggert's avatar
      Avoid some unnecessary stdio.h includes · cebea291
      Paul Eggert authored
      * src/atimer.c, src/callproc.c, src/coding.c, src/dired.c, src/eval.c:
      * src/fringe.c, src/ftcrfont.c, src/ftfont.c, src/ftxfont.c:
      * src/gfilenotify.c, src/indent.c, src/kqueue.c, src/menu.c:
      * src/scroll.c, src/terminal.c, src/unexcoff.c, src/window.c:
      * src/xfont.c, src/xftfont.c:
      Do not include stdio.h since it is unused.
      cebea291
  3. 27 Feb, 2019 1 commit
    • Paul Eggert's avatar
      DEFVAR_INT variables are now intmax_t · e828765d
      Paul Eggert authored
      Formerly they were fixnums, which led to problems when dealing
      with values that might not fit on 32-bit platforms, such as
      string-chars-consed or floats_consed.  64-bit counters should
      be good enough for these (for a while, anyway...).
      While we’re at it, fix some unlikely integer overflow bugs
      that have been in the code for a while.
      * lib-src/make-docfile.c (write_globals):
      * src/data.c (do_symval_forwarding, store_symval_forwarding):
      * src/eval.c (restore_stack_limits, call_debugger):
      * src/frame.h (struct frame.cost_calculation_baud_rate):
      * src/keyboard.c (last_auto_save, bind_polling_period, read_char):
      * src/lisp.h (struct Lisp_Intfwd.intvar):
      * src/lread.c (defvar_int):
      * src/pdumper.c (dump_fwd_int):
      * src/thread.h (struct thread_state.m_lisp_eval_depth):
      * src/undo.c (truncate_undo_list):
      * src/xselect.c (wait_for_property_change)
      (x_get_foreign_selection):
      * src/xterm.c (x_emacs_to_x_modifiers):
      DEFVAR_INT variables now have the C type intmax_t, not EMACS_INT.
      * src/data.c (store_symval_forwarding):
      * src/gnutls.c (Fgnutls_boot):
      * src/keyboard.c (bind_polling_period):
      * src/macros.c (pop_kbd_macro, Fexecute_kbd_macro):
      * src/undo.c (truncate_undo_list):
      Allow any integer that fits into intmax_t, instead of
      requiring it to be a Lisp fixnum.
      * src/dispnew.c (update_window):
      * src/frame.c (x_figure_window_size):
      * src/gnutls.c (init_gnutls_functions)
      (emacs_gnutls_handle_error):
      * src/keyboard.c (make_lisp_event):
      * src/nsterm.m (ns_dumpglyphs_image):
      * src/profiler.c (make_log):
      * src/scroll.c (calculate_scrolling)
      (calculate_direct_scrolling):
      * src/termcap.c (tputs):
      * src/xterm.c (x_draw_image_relief):
      Avoid implementation-defined behavior on conversion of
      out-of-range integers.
      * src/eval.c (when_entered_debugger): Now intmax_t.
      (max_ensure_room): New function, that avoids signed integer overflow.
      (call_debugger, signal_or_quit): Use it.
      * src/fileio.c (Fdo_auto_save):
      * src/keyboard.c (make_lisp_event):
      * src/term.c (calculate_costs):
      * src/xdisp.c (build_desired_tool_bar_string)
      (hscroll_window_tree, try_scrolling, decode_mode_spec)
      (x_produce_glyphs):
      Avoid signed integer overflow.
      * src/lisp.h (clip_to_bounds): Generalize to intmax_t.
      * src/pdumper.c (dump_emacs_reloc_immediate_emacs_int): Remove, ...
      (dump_emacs_reloc_immediate_intmax_t): ... replacing with this
      function.  All uses changed.
      * src/profiler.c (make_log): Omit args.  All callers changed.
      * src/termcap.c: Include stdlib.h, for atoi.
      Include intprops.h.
      * src/window.c (sanitize_next_screen_context_lines): New function.
      (window_scroll_pixel_based, window_scroll_line_based):
      Use it to avoid signed integer overflow.
      e828765d
  4. 01 Jan, 2019 1 commit
  5. 08 Oct, 2018 1 commit
    • Scott Corley's avatar
      Fix overflow lockup with frames > 255 lines · 940ae156
      Scott Corley authored
      Backport from master.
      * src/scroll.c (struct matrix_elt): Change unsigned char fields to
      int to handle frames with more than 255 lines (Bug#32951).
      Copyright-paperwork-exempt: yes
      940ae156
  6. 07 Oct, 2018 2 commits
  7. 31 Aug, 2018 1 commit
    • Paul Eggert's avatar
      Rename Emacs-specific INFINITY constants · 222b5970
      Paul Eggert authored
      Although these constants were not erroneous, as they were
      used only in modules that did not include <math.h>, it's
      less confusing to names that cannot be confused with
      the now-standard INFINITY macro.
      * src/dispextern.h (SCROLL_INFINITY): New constant.
      * src/dispnew.c, src/scroll.c (INFINITY):
      Remove.  All uses replaced with SCROLL_INFINITY.
      * src/process.c (wait_reading_process_output):
      Rename private constant.
      222b5970
  8. 01 Jan, 2018 1 commit
  9. 10 Oct, 2017 1 commit
  10. 13 Sep, 2017 1 commit
    • Paul Eggert's avatar
      Prefer HTTPS to FTP and HTTP in documentation · bc511a64
      Paul Eggert authored
      Most of this change is to boilerplate commentary such as license URLs.
      This change was prompted by ftp://ftp.gnu.org's going-away party,
      planned for November.  Change these FTP URLs to https://ftp.gnu.org
      instead.  Make similar changes for URLs to other organizations moving
      away from FTP.  Also, change HTTP to HTTPS for URLs to gnu.org and
      fsf.org when this works, as this will further help defend against
      man-in-the-middle attacks (for this part I omitted the MS-DOS and
      MS-Windows sources and the test tarballs to keep the workload down).
      HTTPS is not fully working to lists.gnu.org so I left those URLs alone
      for now.
      bc511a64
  11. 01 Jan, 2017 1 commit
  12. 10 Mar, 2016 1 commit
    • Paul Eggert's avatar
      Rework C source files to avoid ^( · 7352c6c6
      Paul Eggert authored
      Work around Bug#22884 by rewording comments and strings to avoid ‘(’
      at the start of a line unless it starts a function.  This change
      is a short-term hack; in the longer run we plan to fix cc-mode’s
      performance for C files that have ‘(’ at the start of a line in a
      comment or string.
      7352c6c6
  13. 01 Jan, 2016 1 commit
  14. 21 Oct, 2015 1 commit
    • Paul Eggert's avatar
      Include-file cleanup for src directory · 63cfb75f
      Paul Eggert authored
      Omit ‘#include "foo.h"’ unless the file needs foo.h (Bug#21707).
      In a few cases, add ‘#include "foo.h"’ if the file needs foo.h
      but does not include it directly.  As a general rule, a source
      file should include foo.h if it needs the interfaces that foo.h
      defines.
      * src/alloc.c: Don’t include process.h.  Include dispextern.h,
      systime.h.
      * src/atimer.c: Don’t include blockinput.h.
      * src/buffer.c: Include coding.h, systime.h.  Don’t include
      keyboard.h, coding.h.
      * src/callint.c: Don’t include commands.h, keymap.h.
      * src/callproc.c: Don’t include character.h, ccl.h, composite.h,
      systty.h, termhooks.h.
      * src/casetab.c: Don’t include character.h.
      * src/category.c: Don’t include charset.h, keymap.h.
      * src/ccl.h: Don’t include character.h.
      * src/character.c: Don’t include charset.h.
      * src/charset.c: Don’t include disptab.h.
      * src/chartab.c: Don’t include ccl.h.
      * src/cm.c: Don’t include frame.h, termhooks.h.
      * src/cmds.c: Don’t include window.h, dispextern.h.
      * src/coding.c: Don’t include window.h, frame.h.
      * src/composite.c: Include composite.h.  Don’t include window.h,
      font.h.
      * src/data.c: Don’t include syssignal.h, termhooks.h, font.h.
      * src/dbusbind.c: Don’t include frame.h.
      * src/decompress.c: Don’t include character.h.
      * src/dired.c: Don’t include character.h, commands.h, charset.h.
      * src/dispnew.c: Don’t include character.h, indent.h, intervals.h,
      process.h, timespec.h.  Include systime.h.
      * src/doc.c: Include coding.h.  Don’t include keyboard.h.
      * src/editfns.c: Include composite.h.  Don’t include frame.h.
      * src/emacs.c: Include fcntl.h, coding.h.  Don’t include
      commands.h, systty.h..
      * src/fileio.c: Don’t include intervals.h, dispextern.h.
      Include composite.h.
      * src/filelock.c: Don’t include character.h, systime.h.
      * src/fns.c: Don’t include time.h, commands.h, keyboard.h,
      keymap.h, frame.h, blockinput.h, xterm.h.  Include composite.h.
      * src/font.c: Include termhooks.h.
      * src/font.h: Don’t include ccl.h, frame.h.  Add forward decls of
      struct composition_it, struct face, struct glyph_string.
      * src/fontset.c: Don’t include buffer.h, ccl.h, keyboard.h,
      intervals.h, window.h, termhooks.h.
      * src/frame.c: Don’t include character.h, commands.h, font.h.
      * src/frame.h: Don’t include dispextern.h.
      * src/fringe.c: Don’t include character.h.
      * src/ftcrfont.c: Don’t include dispextern.h, frame.h,
      character.h, charset.h, fontset.h.
      * src/ftfont.c: Don’t include frame.h, blockinput.h, coding.h,
      fontset.h.
      * src/ftxfont.c: Don’t include dispextern.h, character.h,
      charset.h, fontset.h.
      * src/gfilenotify.c: Don’t include frame.h, process.h.
      * src/gtkutil.c: Include dispextern.h, frame.h, systime.h.
      Don’t include syssignal.h, buffer.h, charset.h, font.h.
      * src/gtkutil.h: Don’t include frame.h.
      * src/image.c: Include fcntl.h and stdio.h instead of sysstdio.h.
      Don’t include character.h.
      * src/indent.c: Don’t include keyboard.h, termchar.h.
      * src/inotify.c: Don’t include character.h, frame.h.
      * src/insdel.c: Include composite.h.  Don’t include blockinput.h.
      * src/intervals.c: Don’t include character.h, keyboard.h.
      * src/intervals.h: Don’t include dispextern.h, composite.h.
      * src/keyboard.c: Don’t include sysstdio.h, disptab.h, puresize.h.
      Include coding.h.
      * src/keyboard.h: Don’t incldue systime.h.
      * src/keymap.c: Don’t include charset.h, frame.h.
      * src/lread.c: Include dispextern.h and systime.h.
      Don’t include frame.h.  Include systime.h.
      * src/macros.c: Don’t include commands.h, character.h, buffer.h.
      * src/menu.c: Include character.h, coding.h.  Don’t include
      dispextern.h.
      * src/menu.h: Don’t include systime.h.
      * src/minibuf.c: Don’t include commands.h, dispextern.h, syntax.h,
      intervals.h, termhooks.h.
      * src/print.c: Include coding.h.  Don’t include keyboard.h,
      window.h, dispextern.h, termchar.h, termhooks.h, font.h.
      Add forward decl of struct terminal.
      * src/process.c: Don’t include termhooks.h, commands.h,
      dispextern.h, composite.h.
      * src/region-cache.c: Don’t include character.h.
      * src/scroll.c: Don’t include keyboard.h, window.h.
      * src/search.c: Don’t include category.h, commands.h.
      * src/sound.c: Don’t include dispextern.h.
      * src/syntax.c: Don’t include command.h, keymap.h.
      * src/sysdep.c: Don’t include window.h, dispextern.h.
      * src/systime.h: Use ‘#ifdef emacs’, not ‘#ifdef EMACS_LISP_H’,
      * src/term.c: Don’t include systty.h, intervals.h, xterm.h.
      * src/terminal.c: Include character.h.
      Don’t include charset.h, coding.h.
      * src/textprop.c: Don’t include character.h.
      * src/undo.c: Don’t include character.h, commands.h, window.h.
      * src/unexsol.c: Don’t include character.h, charset.h.
      * src/widget.c: Include widget.h.  Don’t include keyboard.h,
      window.h, dispextern.h, blockinput.h, character.h, font.h.
      * src/widgetprv.h: Don’t include widget.h.
      * src/window.c: Don’t include character.h, menu.h, intervals.h.
      * src/xdisp.c: Include composite.h, systime.h.  Don’t include
      macros.h, process.h.
      * src/xfaces.c: Don’t include charset.h, keyboard.h, termhooks.h,
      intervals.h.
      * src/xfns.c: Don’t include menu.h, character.h, intervals.h,
      epaths.h, fontset.h, systime.h, atimer.h, termchar.h.
      * src/xfont.c: Don’t include dispextern.h, fontset.h, ccl.h.
      * src/xftfont.c: Don’t include dispextern.h, character.h, fontset.h.
      * src/xgselect.c: Don’t include timespec.h, frame.h.
      Include systime.h.
      * src/xgselect.h: Don’t include time.h.
      Use a forward decl to struct timespec instead.
      * src/xmenu.c: Don’t include keymap.h, character.h, charset.h,
      dispextern.h.  Include systime.h.
      * src/xml.c: Don’t include character.h.
      * src/xrdb.c [USE_MOTIF]: Don’t include keyboard.h.
      * src/xselect.c: Don’t include dispextern.h, character.h,
      buffer.h, process.h.
      * src/xsmfns.c: Don’t include systime.h, sysselect.h.
      * src/xterm.c: Don’t include syssignal.h, charset.h, disptab.h,
      intervals.h process.h, keymap.h, xgselect.h.  Include composite.h.
      63cfb75f
  15. 28 Jul, 2015 1 commit
    • Paul Eggert's avatar
      Fix subscript error in calculate_direct_scrolling · 1216f733
      Paul Eggert authored
      Use slightly-longer cost vectors.  Without this change,
      calculate_direct_scrolling can have a subscript violation when
      FRAME_LINES (frame) <= delta.
      * src/scroll.c (calculate_scrolling, calculate_direct_scrolling)
      (line_ins_del, do_line_insertion_deletion_costs):
      Allocate and use slightly-larger cost vectors, ones based on
      FRAME_TOTAL_LINES instead of FRAME_LINES.
      1216f733
  16. 01 Jan, 2015 2 commits
  17. 07 Sep, 2014 1 commit
    • Paul Eggert's avatar
      Use SAFE_ALLOCA etc. to avoid unbounded stack allocation. · b3bf18b3
      Paul Eggert authored
      This follows up on the recent thread in emacs-devel on alloca; see:
      http://lists.gnu.org/archive/html/emacs-devel/2014-09/msg00042.html
      This patch also cleans up alloca-related glitches noted while
      examining the code looking for unbounded alloca.
      * alloc.c (listn):
      * callproc.c (init_callproc):
      Rewrite to avoid need for alloca.
      * buffer.c (mouse_face_overlay_overlaps)
      (report_overlay_modification):
      * buffer.h (GET_OVERLAYS_AT):
      * coding.c (make_subsidiaries):
      * doc.c (Fsnarf_documentation):
      * editfns.c (Fuser_full_name):
      * fileio.c (Ffile_name_directory, Fexpand_file_name)
      (search_embedded_absfilename, Fsubstitute_in_file_name):
      * fns.c (Fmake_hash_table):
      * font.c (font_vconcat_entity_vectors, font_update_drivers):
      * fontset.c (fontset_pattern_regexp, Ffontset_info):
      * frame.c (Fmake_terminal_frame, x_set_frame_parameters)
      (xrdb_get_resource, x_get_resource_string):
      * ftfont.c (ftfont_get_charset, ftfont_check_otf, ftfont_drive_otf):
      * ftxfont.c (ftxfont_draw):
      * image.c (xbm_load, xpm_load, jpeg_load_body):
      * keyboard.c (echo_add_key, menu_bar_items, tool_bar_items):
      * keymap.c (Fdescribe_buffer_bindings, describe_map):
      * lread.c (openp):
      * menu.c (digest_single_submenu, find_and_call_menu_selection)
      (find_and_return_menu_selection):
      * print.c (PRINTFINISH):
      * process.c (Fformat_network_address):
      * scroll.c (do_scrolling, do_direct_scrolling, scrolling_1):
      * search.c (search_buffer, Fmatch_data, Fregexp_quote):
      * sound.c (wav_play, au_play):
      * syntax.c (skip_chars):
      * term.c (tty_menu_activate, tty_menu_show):
      * textprop.c (get_char_property_and_overlay):
      * window.c (Fset_window_configuration):
      * xdisp.c (safe__call, next_overlay_change, vmessage)
      (compute_overhangs_and_x, draw_glyphs, note_mouse_highlight):
      * xfaces.c (face_at_buffer_position):
      * xmenu.c (x_menu_show):
      Use SAFE_ALLOCA etc. instead of plain alloca, since the
      allocation size isn't bounded.
      * callint.c (Fcall_interactively): Redo memory_full check
      so that it can be done at compile-time on some platforms.
      * coding.c (MAX_LOOKUP_MAX): New constant.
      (get_translation_table): Use it.
      * callproc.c (call_process): Use SAFE_NALLOCA instead of
      SAFE_ALLOCA, to catch integer overflows on size calculation.
      (exec_failed) [!DOS_NT]: New function.
      (child_setup) [!DOS_NT]: Use it.
      * editfns.c (Ftranspose_regions):
      Hoist USE_SAFE_ALLOC + SAFE_FREE out of 'if'.
      * editfns.c (check_translation):
      Allocate larger buffers on the heap.
      * eval.c (internal_lisp_condition_case):
      Check for MAX_ALLOCA overflow.
      * fns.c (sort_vector): Use SAFE_ALLOCA_LISP rather than Fmake_vector.
      (Fbase64_encode_region, Fbase64_decode_region):
      Avoid unnecessary calls to SAFE_FREE before 'error'.
      * buffer.c (mouse_face_overlay_overlaps):
      * editfns.c (Fget_pos_property, check_translation):
      * eval.c (Ffuncall):
      * font.c (font_unparse_xlfd, font_find_for_lface):
      * ftfont.c (ftfont_drive_otf):
      * keyboard.c (echo_add_key, read_decoded_event_from_main_queue)
      (menu_bar_items, tool_bar_items):
      * sound.c (Fplay_sound_internal):
      * xdisp.c (load_overlay_strings, dump_glyph_row):
      Use an ordinary auto buffer rather than alloca, since the
      allocation size is fixed and small.
      * ftfont.c: Include <c-strcase.h>.
      (matching_prefix): New function.
      (get_adstyle_property): Use it, to avoid need for alloca.
      * keyboard.c (echo_add_key):
      * keymap.c (describe_map): Use ptrdiff_t, not int.
      * keyboard.c (echo_add_key): Prefer sizeof to strlen.
      * keymap.c (Fdescribe_buffer_bindings): Use SBYTES, not SCHARS,
      when counting bytes.
      * lisp.h (xlispstrdupa): Remove, replacing with ...
      (SAFE_ALLOCA_STRING): ... new macro with different API.
      This fixes a portability problem, namely, alloca result
      passed to another function.  All uses changed.
      (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Check for MAX_ALLOCA,
      not MAX_ALLOCA - 1.
      * regex.c (REGEX_USE_SAFE_ALLOCA, REGEX_SAFE_FREE)
      (REGEX_ALLOCATE): New macros.
      (REGEX_REALLOCATE, REGEX_ALLOCATE_STACK, REGEX_REALLOCATE_STACK)
      (REGEX_FREE_STACK, FREE_VARIABLES, re_match_2_internal):
      Use them.
      * xdisp.c (message3): Use SAFE_ALLOCA_STRING rather than doing it
      by hand.
      (decode_mode_spec_coding): Store directly into buf rather than
      into an alloca temporary and copying the temporary to the buf.
      
      Fixes: debbugs:18410
      b3bf18b3
  18. 03 Aug, 2014 1 commit
    • Paul Eggert's avatar
      Avoid undefined behavior with signed left shift. · 8f88f7d3
      Paul Eggert authored
      Caught by 'gcc -fsanitize=undefined'.
      * dispextern.h, scroll.c (scrolling_max_lines_saved, scrolling_1):
      * dispnew.c (line_hash_code, scrolling):
      * scroll.c (calculate_scrolling, calculate_direct_scrolling):
      Use 'unsigned', not 'int', for line hashes.
      (scrolling_max_lines_saved): Avoid mystery constants for hash sizes.
      8f88f7d3
  19. 01 Jan, 2014 1 commit
  20. 11 Aug, 2013 1 commit
    • Paul Eggert's avatar
      Omit some unnecessary casts. · 7d652d97
      Paul Eggert authored
      Many of these go back to the old pre-C89 days, when they may have
      been needed, but we've been assuming C89 or later for a while now.
      * alloc.c (live_string_p, live_cons_p, live_symbol_p)
      (live_float_p, live_misc_p, live_vector_p):
      * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
      (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
      (defvar_per_buffer):
      * callint.c (Fcall_interactively):
      * doc.c (Fsubstitute_command_keys):
      * filelock.c (get_boot_time):
      * frame.c (xrdb_get_resource):
      * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
      (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
      (xg_get_file_name_from_selector, menuitem_destroy_callback)
      (menuitem_highlight_callback, menu_destroy_callback)
      (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
      (xg_tool_bar_callback, xg_get_tool_bar_widgets)
      (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
      (xg_tool_bar_help_callback, tb_size_cb):
      * image.c (xpm_alloc_color, png_read_from_memory)
      (png_read_from_file, png_load_body, our_memory_skip_input_data)
      (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
      (syms_of_image):
      * keymap.c (describe_map):
      * nsfns.m (Fns_display_monitor_attributes_list):
      * nsmenu.m (process_dialog:):
      * nsterm.m (hold_event):
      * process.c (wait_reading_process_output):
      * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
      * scroll.c (do_direct_scrolling, scrolling_1):
      * termcap.c (tgetent):
      * window.c (check_window_containing, add_window_to_list)
      (freeze_window_starts):
      * xdisp.c (compare_overlay_entries, vmessage):
      * xfns.c (x_window, x_get_monitor_attributes_xinerama)
      (x_get_monitor_attributes_xrandr)
      (Fx_display_monitor_attributes_list, x_display_info_for_name)
      (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
      * xfont.c (xfont_match, xfont_open):
      * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
      (menubar_selection_callback, menu_position_func)
      (popup_selection_callback, create_and_show_popup_menu)
      (dialog_selection_callback, create_and_show_dialog):
      * xrdb.c (x_get_string_resource):
      (main) [TESTRM]:
      * xsmfns.c (x_session_check_input):
      * xterm.c (x_draw_glyphless_glyph_string_foreground)
      (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
      (xaw_jump_callback, xaw_scroll_callback):
      Omit unnecessary casts.
      7d652d97
  21. 03 Aug, 2013 1 commit
    • Dmitry Antipov's avatar
      Drop FRAME_PTR typedef. · a10c8269
      Dmitry Antipov authored
      * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
      * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
      * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
      * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
      * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
      * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
      * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
      All related users changed.
      a10c8269
  22. 08 Mar, 2013 1 commit
    • Paul Eggert's avatar
      region-cache.c, scroll.c, search.c: Use bool for booleans. · 457882c2
      Paul Eggert authored
      * lisp.h (compile_pattern):
      * scroll.c (do_scrolling, do_direct_scrolling):
      * search.c (struct regexp_cache, compile_pattern_1)
      (compile_pattern, string_match_1, search_command)
      (trivial_regexp_p, search_buffer, Freplace_match, match_limit)
      (search_regs_saved, Fregexp_quote):
      Use bool for boolean.
      * region-cache.c (region_cache_forward, region_cache_backward):
      Fix comments to match code: these functions return int, not boolean.
      457882c2
  23. 01 Jan, 2013 1 commit
  24. 15 Sep, 2012 1 commit
    • Paul Eggert's avatar
      Port better to POSIX hosts lacking _setjmp. · 0328b6de
      Paul Eggert authored
      * configure.ac (HAVE__SETJMP, HAVE_SIGSETJMP): New symbols.
      (_setjmp, _longjmp): Remove.
      * src/lisp.h: Include <setjmp.h> here, since we use its symbols here.
      All instances of '#include <setjmp.h>' removed, if the
      only reason for the instance was because "lisp.h" was included.
      (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
      Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
      and _longjmp with the new symbols.  Emacs already uses _setjmp if
      available, so this change affects only POSIXish hosts that have
      sigsetjmp but not _setjmp, such as some versions of Solaris and
      Unixware.  (Also, POSIX-2008 marks _setjmp as obsolescent.)
      * src/image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
      (png_load_body) [HAVE_PNG]:
      (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
      (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
      Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
      since PNG requires jmp_buf.  This is the only exception to the
      general rule that we now use sys_setjmp and sys_longjmp.
      This exception is OK since this code does not change the signal
      mask or longjmp out of a signal handler.
      
      Fixes: debbugs:12446
      0328b6de
  25. 04 Sep, 2012 1 commit
    • Paul Eggert's avatar
      Simplify redefinition of 'abort' (Bug#12316). · 1088b922
      Paul Eggert authored
      Do not try to redefine the 'abort' function.  Instead, redo
      the code so that it calls 'emacs_abort' rather than 'abort'.
      This removes the need for the NO_ABORT configure-time macro
      and makes it easier to change the abort code to do a backtrace.
      * configure.ac (NO_ABRT): Remove.
      * admin/CPP-DEFINES (NO_ABORT): Remove.
      * nt/inc/ms-w32.h (w32_abort) [HAVE_NTGUI]: Remove.
      * src/.gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
      * src/emacs.c (abort) [!DOS_NT && !NO_ABORT]:
      Remove; sysdep.c's emacs_abort now takes its place.
      * src/lisp.h (emacs_abort): New decl.  All calls from Emacs code to
      'abort' changed to use 'emacs_abort'.
      * src/msdos.c (dos_abort) [defined abort]: Remove; not used.
      (abort) [!defined abort]: Rename to ...
      (emacs_abort): ... new name.
      * src/sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
      the place of the old 'abort' in emacs.c.
      * src/w32.c, src/w32fns.c (abort): Do not #undef.
      * src/w32.c (emacs_abort): Rename from w32_abort.
      1088b922
  26. 05 Jul, 2012 1 commit
    • Paul Eggert's avatar
      More xmalloc and related cleanup. · 38182d90
      Paul Eggert authored
      * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
      * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
      * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
      * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
      * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
      * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
      * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
      * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
      * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
      * xterm.c:
      Omit needless casts involving void * pointers and allocation.
      Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
      as the former is more robust if P's type is changed.
      Prefer xzalloc to xmalloc + memset 0.
      Simplify malloc-or-realloc to realloc.
      Don't worry about xmalloc returning a null pointer.
      Prefer xstrdup to xmalloc + strcpy.
      * editfns.c (Fmessage_box): Grow message_text by at least 80 when
      growing it.
      * keyboard.c (apply_modifiers_uncached): Prefer local array to
      alloca of a constant.
      38182d90
  27. 28 Jun, 2012 2 commits
    • Dmitry Antipov's avatar
      * configure.in: Add glyphs category to --enable-checking option. · e509cfa6
      Dmitry Antipov authored
      (GLYPH_DEBUG): Define if glyphs debugging is enabled.
      * src/dispextern.h (GLYPH_DEBUG): Now defined in config.h if
      enabled with --enable-checking=[all,glyphs] configure option.
      Fix GLYPH_DEBUG usage assuming that it may be undefined,
      adjust comments accordingly.
      * src/dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
      undefined, adjust comments accordingly.
      * src/image.c: Likewise.
      * src/scroll.c: Likewise.
      * src/w32fns.c: Likewise.
      * src/w32term.c: Likewise.
      * src/xdisp.c: Likewise.
      * src/xfaces.c: Likewise.
      * src/xfns.c: Likewise.
      * src/xterm.c: Likewise.
      e509cfa6
    • Dmitry Antipov's avatar
      Generalize run-time debugging checks. · a54e2c05
      Dmitry Antipov authored
      * configure.in (ENABLE_CHECKING): Update comment.
      * src/dispextern.h (XASSERTS): Remove.
      * src/fontset.c (xassert): Remove.
      Convert from xassert to eassert.
      * src/alloc.c: Convert from xassert to eassert.
      * src/bidi.c: Likewise.
      * src/dispnew.c: Likewise.
      * src/fns.c: Likewise.
      * src/fringe.c: Likewise.
      * src/ftfont.c: Likewise.
      * src/gtkutil.c: Likewise.
      * src/image.c: Likewise.
      * src/keyboard.c: Likewise.
      * src/menu.c: Likewise.
      * src/process.c: Likewise.
      * src/scroll.c: Likewise.
      * src/sound.c: Likewise.
      * src/term.c: Likewise.
      * src/w32console.c: Likewise.
      * src/w32fns.c: Likewise.
      * src/w32term.c: Likewise.
      * src/window.c: Likewise.
      * src/xdisp.c: Likewise.
      * src/xfaces.c: Likewise.
      * src/xfns.c: Likewise.
      * src/xselect.c: Likewise.
      * src/xterm.c: Likewise.
      a54e2c05
  28. 11 Jan, 2012 1 commit
  29. 05 Jan, 2012 1 commit
  30. 21 Sep, 2011 1 commit
    • Paul Eggert's avatar
      * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp): · d311d28c
      Paul Eggert authored
      (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
      (string_bytes, check_sblock, allocate_string_data):
      (compact_small_strings, Fmake_bool_vector, make_string)
      (make_unibyte_string, make_multibyte_string)
      (make_string_from_bytes, make_specified_string)
      (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
      (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
      (mark_vectorlike):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (allocate_pseudovector):
      Use int, not EMACS_INT, where int is wide enough.
      (inhibit_garbage_collection, Fgarbage_collect):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
      int might not be wide enough.
      (bidi_cache_search, bidi_cache_find, bidi_init_it)
      (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
      (bidi_at_paragraph_end, bidi_find_paragraph_start)
      (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
      (bidi_level_of_next_char, bidi_move_to_visually_next):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
      (Fkill_buffer, Fset_buffer_major_mode)
      (advance_to_char_boundary, Fbuffer_swap_text)
      (Fset_buffer_multibyte, overlays_at, overlays_in)
      (overlay_touches_p, struct sortvec, record_overlay_string)
      (overlay_strings, recenter_overlay_lists)
      (adjust_overlays_for_insert, adjust_overlays_for_delete)
      (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
      (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
      (Foverlay_recenter, last_overlay_modification_hooks_used)
      (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (validate_region): Omit unnecessary test for b <= e, since
      that's guaranteed by the previous test.
      (adjust_overlays_for_delete): Avoid pos + length overflow.
      (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
      (report_overlay_modification):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
      Omit pointer cast, which isn't needed anyway, and doesn't work
      after the EMACS_INT -> ptrdiff_t change.
      * buffer.h: Adjust decls to match defn changes elsewhere.
      (struct buffer_text, struct buffer):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Use EMACS_INT, not int, where int might not be wide enough.
      * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
      needless 32-bit limit on 64-bit hosts.  Remove unnecessary
      memory-full test.  Use EMACS_INT, not ptrdiff_t or int, where
      ptrdiff_t or int might not be wide enough.
      * callint.c (Fcall_interactively):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * callproc.c (call_process_kill, Fcall_process):
      Don't assume pid_t fits into an Emacs fixnum.
      (call_process_cleanup, Fcall_process, child_setup):
      Don't assume pid_t fits into int.
      (call_process_cleanup, Fcall_process, delete_temp_file)
      (Fcall_process_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fcall_process): Simplify handling of volatile integers.
      Use int, not EMACS_INT, where int will do.
      * casefiddle.c (casify_object, casify_region, operate_on_word)
      (Fupcase_word, Fdowncase_word, Fcapitalize_word):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (casify_object): Avoid integer overflow when overallocating buffer.
      * casetab.c (set_identity, shuffle): Prefer int to unsigned when
      either works.
      * category.c (Fchar_category_set): Don't assume fixnum fits in int.
      * category.h (CATEGORYP): Don't assume arg is nonnegative.
      * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
      integers are now checked earlier.  All uses replaced with XINT.
      (ccl_driver):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      For CCL_MapSingle, check that content and value are in int range.
      (resolve_symbol_ccl_program): Check that vector header is in range.
      Always copy the vector, so that we can check its contents reliably
      now rather than having to recheck each instruction as it's being
      executed.  Check that vector words fit in 'int'.
      (ccl_get_compiled_code, Fregister_ccl_program)
      (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
      program indexes, to avoid needless 32-bit limit on 64-bit hosts.
      (Fccl_execute, Fccl_execute_on_string): Check that initial reg
      contents are in range.
      (Fccl_execute_on_string): Check that status is in range.
      * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
      * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
      Accept and return EMACS_INT, not int, because callers can pass values
      out of 'int' range.
      (c_string_width, strwidth, lisp_string_width, chars_in_text)
      (multibyte_chars_in_text, parse_str_as_multibyte)
      (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
      (str_as_unibyte, str_to_unibyte, string_count_byte8)
      (string_escape_byte8, Fget_byte):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
      avoid mishandling large integers.
      * character.h: Adjust decls to match defn changes elsewhere.
      * charset.c (load_charset_map_from_file, find_charsets_in_text)
      (Ffind_charset_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (load_charset_map_from_file): Redo idx calculation to avoid overflow.
      (load_charset_map_from_vector, Fdefine_charset_internal):
      Don't assume fixnum fits in int or unsigned int.
      (load_charset_map_from_vector, Fmap_charset_chars):
      Remove now-unnecessary CHECK_NATNUMs.
      (Fdefine_charset_internal): Check ranges here, more carefully.
      * chartab.c (Fmake_char_table, Fset_char_table_range)
      (uniprop_get_decoder, uniprop_get_encoder):
      Don't assume fixnum fits in int.
      * cmds.c (move_point): New function, that does the gist of
      Fforward_char and Fbackward_char, but does so while checking
      for integer overflow more accurately.
      (Fforward_char, Fbackward_char, internal_self_insert): Use it.
      (Fforward_line, Fend_of_line, internal_self_insert)
      (internal_self_insert):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Fix a FIXME, by checking for integer overflow when calculating
      target_clm and actual_clm.
      * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
      (ASSURE_DESTINATION, coding_alloc_by_realloc)
      (coding_alloc_by_making_gap, alloc_destination)
      (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
      (encode_coding_utf_16, detect_coding_emacs_mule)
      (decode_coding_emacs_mule, encode_coding_emacs_mule)
      (detect_coding_iso_2022, decode_coding_iso_2022)
      (encode_invocation_designation, encode_designation_at_bol)
      (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
      (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
      (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
      (encode_coding_ccl, encode_coding_raw_text)
      (detect_coding_charset, decode_coding_charset)
      (encode_coding_charset, detect_eol, decode_eol, produce_chars)
      (produce_composition, produce_charset, produce_annotation)
      (decode_coding, handle_composition_annotation)
      (handle_charset_annotation, consume_chars, decode_coding_gap)
      (decode_coding_object, encode_coding_object, detect_coding_system)
      (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
      (code_convert_region, code_convert_string)
      (Fdefine_coding_system_internal):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
      (Fdefine_coding_system_internal):
      Don't assume fixnums fit in int.
      (decode_coding_gap, decode_coding_object, encode_coding_object)
      (Fread_coding_system, Fdetect_coding_region, Funencodable_char_position)
      (Fcheck_coding_systems_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
      (Fdefine_coding_system_internal): Check for charset-id overflow.
      * coding.h: Adjust decls to match defn changes elsewhere.
      (struct coding_system):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * composite.c (get_composition_id, find_composition)
      (run_composition_function, update_compositions)
      (compose_text, composition_gstring_put_cache)
      (composition_gstring_p, composition_gstring_width)
      (fill_gstring_header, fill_gstring_body, autocmp_chars)
      (composition_compute_stop_pos, composition_reseat_it)
      (composition_update_it, struct position_record)
      (find_automatic_composition, composition_adjust_point)
      (Fcomposition_get_gstring, Ffind_composition_internal):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (update_compositions):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * composite.h: Adjust decls to match defn changes elsewhere.
      (struct composition):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
      Do not attempt to compute the address of the object just before a
      buffer; this is not portable.
      (Faref, Faset):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Faset): Use int, not EMACS_INT, where int is wide enough.
      (Fstring_to_number): Don't assume fixnums fit in int.
      (Frem): Don't assume arg is nonnegative.
      * dbusbind.c (xd_append_arg): Check for integers out of range.
      (Fdbus_call_method): Don't overflow the timeout int.
      * dired.c (directory_files_internal, file_name_completion, scmp)
      (file_name_completion_stat):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (file_name_completion): Don't overflow matchcount.
      (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
      * dispextern.h: Adjust decls to match defn changes elsewhere.
      (struct text_pos, struct glyph, struct bidi_saved_info)
      (struct bidi_string_data, struct bidi_it, struct composition_it)
      (struct it):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (struct display_pos, struct composition_it, struct it):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * dispnew.c (increment_matrix_positions)
      (increment_row_positions, mode_line_string)
      (marginal_area_string):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (change_frame_size_1, Fredisplay):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (duration_to_sec_usec): New function, to check for overflow better.
      (Fsleep_for, sit_for): Use it.
      * doc.c (get_doc_string, store_function_docstring):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (get_doc_string, Fsnarf_documentation):
      Use int, not EMACS_INT, where int is wide enough.
      (get_doc_string):
      Use SAFE_ALLOCA, not alloca.
      Check for overflow when converting EMACS_INT to off_t.
      * doprnt.c (doprnt):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
      Don't assume uid_t fits into fixnum.
      (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
      (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
      (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
      (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
      (general_insert_function)
      (Finsert_char, make_buffer_string, make_buffer_string_both)
      (update_buffer_properties, Fbuffer_substring)
      (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
      (Fsubst_char_in_region, check_translation)
      (Ftranslate_region_internal, save_restriction_restore, Fformat)
      (transpose_markers, Ftranspose_regions):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (clip_to_bounds): Move to lisp.h as an inline function).
      (Fconstrain_to_field): Don't assume integers are nonnegative.
      (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
      (Fsubst_char_in_region, Fsave_restriction):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Femacs_pid): Don't assume pid_t fits into fixnum.
      (lo_time): Use int, not EMACS_INT, when int suffices.
      (lisp_time_argument): Check for usec out of range.
      (Fencode_time): Don't assume fixnum fits in int.
      * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
      (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
      (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
      (init_cmdargs, Fdump_emacs):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
      the bottom (typically) 32 bits of the fixnum.
      * eval.c (specpdl_size, call_debugger):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (when_entered_debugger, Fbacktrace_debug):
      Don't assume fixnum can fit in int.
      (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
      the object just before a buffer; this is not portable.
      (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
      (grow_specpdl, unbind_to):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
      (grow_specpdl): Simplify allocation by using xpalloc.
      * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
      (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
      (a_write, e_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fcopy_file, non_regular_nbytes, read_non_regular)
      (Finsert_file_contents):
      Use int, not EMACS_INT, where int is wide enough.
      (READ_BUF_SIZE): Verify that it fits in int.
      (Finsert_file_contents): Check that counts are in proper range,
      rather than assuming fixnums fit into ptrdiff_t etc.
      Don't assume fixnums fit into int.
      (Fdo_auto_save, Fset_buffer_auto_saved)
      (Fclear_buffer_auto_save_failure):
      Don't assume time_t is signed, or that it fits in int.
      * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec)
      (concat, string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
      (string_char_to_byte, string_byte_to_char)
      (string_make_multibyte, string_to_multibyte)
      (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
      (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
      (substring_both, Fdelete, internal_equal, Ffillarray)
      (Fclear_string, mapcar1)
      (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
      (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
      (larger_vector, make_hash_table, maybe_resize_hash_table)
      (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
      (Fmaphash, secure_hash):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (concat): Check for string index and length overflow.
      (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
      (Frequire):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (larger_vector): New API (vec, incr_min, size_max) replaces old
      one (vec, new_size, init).  This catches size overflow.
      INIT was removed because it was always Qnil.
      All callers changed.
      (INDEX_SIZE_BOUND): New macro, which calculates more precisely
      the upper bound on a hash table index size.
      (make_hash_table, maybe_resize_hash_table): Use it.
      (secure_hash): Computer start_byte and end_byte only after
      they're known to be in ptrdiff_t range.
      * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
      (Ffont_get_glyphs, Ffont_at):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
      (Flist_fonts, Fopen_font):
      Don't assume fixnum can fit in int.
      (check_gstring): Don't assume index can fit in int.
      (font_match_p): Check that fixnum is a character, not a nonnegative
      fixnum, since the later code needs to stuff it into an int.
      (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
      (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
      conversion overflow issues.
      (Fopen_font): Check for integer out of  range.
      (Ffont_get_glyphs): Don't assume index can fit in int.
      * font.h: Adjust decls to match defn changes elsewhere.
      * fontset.c (reorder_font_vector): Redo score calculation to avoid
      integer overflow.
      (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
      printmax_t, where ptrdiff_t is wide enough.
      (Finternal_char_font):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
      (Fset_frame_height, Fset_frame_width, Fset_frame_size)
      (Fset_frame_position, x_set_frame_parameters)
      (x_set_line_spacing, x_set_border_width)
      (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
      Check that fixnums are in proper range for system types.
      (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fmodify_frame_parameters): Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
      intptr_t is wide enough.
      * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
      (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
      (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
      Check for fixnum out of range.
      * ftfont.c (ftfont_list): Don't assume index fits in int.
      Check that fixnums are in proper range for system types.
      (ftfont_shape_by_flt):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Remove no-longer-needed lint_assume.
      * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
      Check that fixnums are in proper range for system types.
      * gnutls.h: Adjust decls to match defn changes elsewhere.
      * gtkutil.c (xg_dialog_run):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (update_frame_tool_bar):
      Check that fixnums are in proper range for system types.
      * image.c (parse_image_spec): Redo count calculation to avoid overflow.
      (lookup_image): Check that fixnums are in proper range for system types.
      * indent.c (last_known_column, last_known_column_point):
      (current_column_bol_cache):
      (skip_invisible, current_column, check_display_width):
      (check_display_width, scan_for_column, current_column_1)
      (Findent_to, Fcurrent_indentation, position_indentation)
      (indented_beyond_p, Fmove_to_column, compute_motion):
      (Fcompute_motion, Fvertical_motion):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (last_known_column_modified): Use EMACS_INT, not int.
      (check_display_width):
      (Fcompute_motion):
      Check that fixnums and floats are in proper range for system types.
      (compute_motion): Don't assume index or fixnum fits in int.
      (compute_motion, Fcompute_motion):
      Use int, not EMACS_INT, when it is wide enough.
      (vmotion): Omit local var start_hpos that is always 0; that way
      we don't need to worry about overflow in expressions involving it.
      * indent.h: Adjust decls to match defn changes elsewhere.
      (struct position):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Use int, not EMACS_INT, where int is wide enough.
      Remove unused members ovstring_chars_done and tab_offset;
      all uses removed.
      * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
      (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
      (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
      (make_gap, copy_text, insert, insert_and_inherit)
      (insert_before_markers, insert_before_markers_and_inherit)
      (insert_1, count_combining_before, count_combining_after)
      (insert_1_both, insert_from_string)
      (insert_from_string_before_markers, insert_from_string_1)
      (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
      (adjust_after_replace, adjust_after_insert, replace_range)
      (replace_range_2, del_range, del_range_1, del_range_byte)
      (del_range_both, del_range_2, modify_region)
      (prepare_to_modify_buffer, signal_before_change)
      (signal_after_change, Fcombine_after_change_execute):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * intervals.c (traverse_intervals, rotate_right, rotate_left)
      (balance_an_interval, split_interval_right, split_interval_left)
      (find_interval, next_interval, update_interval)
      (adjust_intervals_for_insertion, delete_node, delete_interval)
      (interval_deletion_adjustment, adjust_intervals_for_deletion)
      (static_offset_intervals, offset_intervals)
      (merge_interval_right, merge_interval_left, make_new_interval)
      (graft_intervals_into_buffer, temp_set_point_both)
      (temp_set_point, set_point, adjust_for_invis_intang)
      (set_point_both, move_if_not_intangible, get_property_and_range)
      (get_local_map, copy_intervals, copy_intervals_to_string)
      (compare_string_intervals, set_intervals_multibyte_1):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * intervals.h: Adjust decls to match defn changes elsewhere.
      (struct interval):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * keyboard.c (this_command_key_count, this_single_command_key_start)
      (before_command_key_count, before_command_echo_length, echo_now)
      (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
      (command_loop_1, safe_run_hooks, read_char, timer_check_2)
      (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
      (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (last_non_minibuf_size, last_point_position, echo_truncate)
      (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
      (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
      (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
      (stuff_buffered_input):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (last_auto_save, command_loop_1, read_char):
      Use EMACS_INT, not int, to avoid integer overflow.
      (record_char): Avoid overflow in total_keys computation.
      (parse_modifiers_uncached): Redo index calculation to avoid overflow.
      * keyboard.h: Adjust decls to match defn changes elsewhere.
      * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
      (Fkey_description, Fdescribe_vector, Flookup_key):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (click_position): New function, to check that positions are in range.
      (Fcurrent_active_maps):
      (describe_command):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Faccessible_keymaps, Fkey_description):
      (preferred_sequence_p):
      Don't assume fixnum can fit into int.
      (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
      Check for integer overflow in size calculations.
      (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
      avoid mishandling large integers.
      * lisp.h: Adjust decls to match defn changes elsewhere.
      (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
      (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
      (struct Lisp_Marker):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (clip_to_bounds): Now an inline function, moved here from editfns.c.
      (XSETSUBR): Use size of 0 since the actual size doesn't matter,
      and using 0 avoids overflow.
      (GLYPH_CODE_P): Check for overflow in system types, subsuming the
      need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
      All callers changed.
      (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
      Assume the arg has valid form, since it always does.
      (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
      unsigned integer system type.
      (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
      (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
      (duration_to_sec_usec): New decl.
      * lread.c (read_from_string_index, read_from_string_index_byte)
      (read_from_string_limit, readchar, unreadchar, openp)
      (read_internal_start, read1, oblookup):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fload, readevalloop, Feval_buffer, Feval_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (openp): Check for out-of-range argument to 'access'.
      (read1): Use int, not EMACS_INT, where int is wide enough.
      Don't assume fixnum fits into int.
      * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
      in size calculation.
      (Fexecute_kbd_macro):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * marker.c (cached_charpos, cached_bytepos, CONSIDER)
      (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
      (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
      (set_marker_both, set_marker_restricted_both, marker_position)
      (marker_byte_position, Fbuffer_has_markers_at):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
      * menu.c (ensure_menu_items): Renamed from grow_menu_items.
      It now merely ensures that the menu is large enough, without
      necessarily growing it, as this avoids some integer overflow issues.
      All callers changed.
      (keymap_panes, parse_single_submenu, Fx_popup_menu):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      (find_and_return_menu_selection): Avoid unnecessary casts of pointers
      to EMACS_INT.  Check that fixnums are in proper range for system types.
      * minibuf.c (minibuf_prompt_width, string_to_object)
      (Fminibuffer_contents, Fminibuffer_contents_no_properties)
      (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (get_minibuffer, read_minibuf_unwind):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
      this simplifies overflow checking.  All callers changed.
      (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
      (Ftest_completion):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
      (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
      Check that fixnums are in proper range for system types.
      (Fx_create_frame, Fx_show_tip):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * nsfont.m (ns_findfonts, nsfont_list_family):
      Don't assume fixnum fits in long.
      * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
      wide enough.
      * nsselect.m (ns_get_local_selection):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
      (PRINTDECLARE, PRINTPREPARE):
      (strout, print_string):
      (print, print_preprocess, print_check_string_charset_prop)
      (print_object):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (PRINTDECLARE):
      (temp_output_buffer_setup, Fprin1_to_string, print_object):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
      (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
      (printchar, strout): Use xpalloc to catch size calculation overflow.
      (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
      to avoid mishandling large integers.
      (print_error_message): Use SAFE_ALLOCA, not alloca.
      (print_object): Use int, not EMACS_INT, where int is wide enough.
      * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
      (Fset_process_window_size, Fformat_network_address)
      (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
      (Fsignal_process, sigchld_handler):
      Check that fixnums are in proper range for system types.
      (Fformat_network_address, read_process_output, send_process)
      (Fprocess_send_region, status_notify):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
      (wait_reading_process_output, read_process_output, exec_sentinel):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
      (Faccept_process_output): Use duration_to_sec_usec to do proper
      overflow checking on durations.
      * scroll.c (calculate_scrolling, calculate_direct_scrolling)
      (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
      * search.c (looking_at_1, string_match_1):
      (fast_string_match, fast_c_string_match_ignore_case)
      (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
      (scan_newline, find_before_next_newline, search_command)
      (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
      (set_search_regs, wordify):
      (Freplace_match):
      (Fmatch_data):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (string_match_1, search_buffer, set_search_regs):
      (Fmatch_data):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (wordify): Check for overflow in size calculation.
      (Freplace_match): Avoid potential buffer overflow in search_regs.start.
      (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
      Check that fixnums are in proper range for system types.
      * sound.c (struct sound_device)
      (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fplay_sound_internal):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
      In definitions, make it clearer that these values must be out of range
      for the respective integer ranges.  This fixes a bug with ST_STRING_STYLE
      and non-ASCII characters.
      (struct lisp_parse_state, find_start_modiff)
      (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
      (Fparse_partial_sexp):
      Don't assume fixnums can fit in int.
      (struct lisp_parse_state, find_start_pos, find_start_value)
      (find_start_value_byte, find_start_begv)
      (update_syntax_table, char_quoted, dec_bytepos)
      (find_defun_start, prev_char_comend_first, back_comment):
      (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
      (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Finternal_describe_syntax_value): Check that match_lisp is a
      character, not an integer, since the code stuffs it into int.
      (scan_words, scan_sexps_forward):
      Check that fixnums are in proper range for system types.
      (Fforward_word):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (scan_sexps_forward):
      Use CHARACTERP, not INTEGERP, since the value must fit into int.
      (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
      * syntax.h: Adjust decls to match defn changes elsewhere.
      (struct gl_state_s):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * sysdep.c (wait_for_termination_1, wait_for_termination)
      (interruptible_wait_for_termination, mkdir):
      Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
      (emacs_read, emacs_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (system_process_attributes): Don't assume uid_t, gid_t, and
      double all fit in int or even EMACS_INT.
      * term.c (set_tty_color_mode):
      Check that fixnums are in proper range for system types.
      * termhooks.h (struct input_event):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * textprop.c (validate_interval_range, interval_of)
      (Fadd_text_properties, set_text_properties_1)
      (Fremove_text_properties, Fremove_list_of_text_properties)
      (Ftext_property_any, Ftext_property_not_all)
      (copy_text_properties, text_property_list, extend_property_ranges)
      (verify_interval_modification):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fnext_single_char_property_change)
      (Fprevious_single_char_property_change):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (copy_text_properties): Check for integer overflow in index calculation.
      * undo.c (last_boundary_position, record_point, record_insert)
      (record_delete, record_marker_adjustment, record_change)
      (record_property_change):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
      (Fx_hide_tip, Fx_file_dialog):
      * w32menu.c (set_frame_menubar):
      Use ptrdiff_t, not int, for consistency with rest of code.
      * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
      (select_window, Fdelete_other_windows_internal)
      (window_scroll_pixel_based, window_scroll_line_based)
      (Frecenter, Fset_window_configuration):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fset_window_hscroll, run_window_configuration_change_hook)
      (set_window_buffer, temp_output_buffer_show, scroll_command)
      (Fscroll_other_window):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
      Don't assume fixnum fits in int.
      (Fset_window_scroll_bars):
      Check that fixnums are in proper range for system types.
      * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
      (string_pos, c_string_pos, number_of_chars, init_iterator)
      (in_ellipses_for_invisible_text_p, init_from_display_pos)
      (compute_stop_pos, next_overlay_change, compute_display_string_pos)
      (compute_display_string_end, handle_face_prop)
      (face_before_or_after_it_pos, handle_invisible_prop, handle_display_prop)
      (handle_display_spec, handle_single_display_spec)
      (display_prop_intangible_p, string_buffer_position_lim)
      (string_buffer_position, handle_composition_prop, load_overlay_strings)
      (get_overlay_strings_1, get_overlay_strings)
      (iterate_out_of_display_property, forward_to_next_line_start)
      (back_to_previous_visible_line_start, reseat, reseat_to_string)
      (get_next_display_element, set_iterator_to_next)
      (get_visually_first_element, compute_stop_pos_backwards)
      (handle_stop_backwards, next_element_from_buffer)
      (move_it_in_display_line_to, move_it_in_display_line)
      (move_it_to, move_it_vertically_backward, move_it_by_lines)
      (add_to_log, message_dolog, message_log_check_duplicate)
      (message2, message2_nolog, message3, message3_nolog
      (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
      (current_message_1, truncate_echo_area, truncate_message_1)
      (set_message, set_message_1, store_mode_line_noprop)
      (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
      (text_outside_line_unchanged_p, check_point_in_composition)
      (reconsider_clip_changes)
      (redisplay_internal, set_cursor_from_row, try_scrolling)
      (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
      (redisplay_window, find_last_unchanged_at_beg_row)
      (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
      (trailing_whitespace_p, find_row_edges, display_line)
      (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
      (display_mode_element, store_mode_line_string)
      (pint2str, pint2hrstr, decode_mode_spec)
      (display_count_lines, display_string, draw_glyphs)
      (x_produce_glyphs, x_insert_glyphs)
      (rows_from_pos_range, mouse_face_from_buffer_pos)
      (fast_find_string_pos, mouse_face_from_string_pos)
      (note_mode_line_or_margin_highlight, note_mouse_highlight):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (safe_call, init_from_display_pos, handle_fontified_prop)
      (handle_single_display_spec, load_overlay_strings)
      (with_echo_area_buffer, setup_echo_area_for_printing)
      (display_echo_area, echo_area_display)
      (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
      (update_tool_bar, hscroll_window_tree, redisplay_internal)
      (redisplay_window, dump_glyph_row, display_mode_line, Fformat_mode_line)
      (decode_mode_spec, on_hot_spot_p):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (handle_single_display_spec, build_desired_tool_bar_string)
      (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
      (get_specified_cursor_type):
      Check that fixnums are in proper range for system types.
      (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
      (Flookup_image_map):
      Don't assume fixnums fit in int.
      (compare_overlay_entries):
      Avoid mishandling comparisons due to subtraction overflow.
      (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
      (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
      (handle_tool_bar_click):
      Use int, not unsigned, since we prefer signed and the signedness
      doesn't matter here.
      (get_next_display_element, next_element_from_display_vector):
      Use int, not EMACS_INT, when int is wide enough.
      (start_hourglass): Use duration_to_sec_usec to do proper
      overflow checking on durations.
      * xfaces.c (Fbitmap_spec_p):
      Check that fixnums are in proper range for system types.
      (compare_fonts_by_sort_order):
      Avoid mishandling comparisons due to subtraction overflow.
      (Fx_family_fonts, realize_basic_faces):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fx_family_fonts):
      Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      (merge_face_heights): Remove unnecessary cast to EMACS_INT.
      (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
      (face_at_buffer_position, face_for_overlay_string)
      (face_at_string_position):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (merge_faces): Use int, not EMACS_INT, where int is wide enough.
      * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
      (Fx_show_tip):
      Check that fixnums are in proper range for system types.
      (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
      (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fx_change_window_property): Don't assume fixnums fit in int.
      * xfont.c (xfont_chars_supported):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xmenu.c (Fx_popup_dialog, set_frame_menubar)
      (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xml.c (parse_region):
      * xrdb.c (magic_file_p):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * xselect.c (TRACE1): Don't assume pid_t promotes to int.
      (x_get_local_selection, x_reply_selection_request)
      (x_handle_selection_request, wait_for_property_change):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (selection_data_to_lisp_data): Use short, not EMACS_INT, where
      short is wide enough.
      (x_send_client_event): Don't assume fixnum fits in int.
      * xterm.c (x_x_to_emacs_modifiers):
      Don't assume EMACS_INT overflows nicely into int.
      (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
      may come from Lisp.
      (handle_one_xevent): NATNUMP can eval its arg twice.
      (x_connection_closed):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xterm.h: Adjust decls to match defn changes elsewhere.
      (struct scroll_bar): Use struct vectorlike_header
      rather than rolling our own approximation.
      (SCROLL_BAR_VEC_SIZE): Remove; not used.
      d311d28c
  31. 05 Aug, 2011 1 commit
  32. 29 Jul, 2011 1 commit
  33. 22 Jun, 2011 1 commit
    • Paul Eggert's avatar
      GLYPH_DEBUG fixes · 85fece3e
      Paul Eggert authored
      The following patches are for when GLYPH_DEBUG && !XASSERT.
      * dispextern.h (trace_redisplay_p, dump_glyph_string):
      * dispnew.c (flush_stdout):
      * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
      Mark as externally visible.
      * dispnew.c (check_window_matrix_pointers): Now static.
      * dispnew.c (window_to_frame_vpos):
      * xfns.c (unwind_create_frame):
      * xterm.c (x_check_font): Remove unused local.
      * scroll.c (CHECK_BOUNDS):
      * xfaces.c (cache_fache): Rename local to avoid shadowing.
      * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
      * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
      (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
      (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
      Now static.
      (debug_method_add): Use va_list and vsprintf rather than relying
      on undefined behavior with wrong number of arguments.
      (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
      Don't assume ptrdiff_t and EMACS_INT are the same width as int.
      In this code, it's OK to assume C99 behavior for ptrdiff_t formats
      since we're not interested in debugging glyphs with old libraries.
      * xfaces.c (cache_face): Move debugging code earlier; this pacifies
      GCC 4.6.0's static checking.
      85fece3e
  34. 14 Apr, 2011 1 commit
  35. 29 Mar, 2011 1 commit
  36. 22 Mar, 2011 1 commit
  37. 09 Mar, 2011 1 commit
    • Paul Eggert's avatar
      * cm.c (calccost, cmgoto): Use const pointers where appropriate. · fbceeba2
      Paul Eggert authored
      * cm.h (struct cm): Likewise.
      * dispextern.h (do_line_insertion_deletion_costs): Likewise.
      * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
      * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
      (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
      (turn_on_face, init_tty): Likewise.
      * termchar.h (struct tty_display_info): Likewise.
      * term.c (tgetflag, tgetnum, tgetstr): Redefine to use const pointers.
      fbceeba2