1. 02 Apr, 2019 8 commits
  2. 01 Apr, 2019 7 commits
    • Eric Abrahamsen's avatar
      Refactor Gnus group name extraction in group completing read · 03ceee0e
      Eric Abrahamsen authored
      * lisp/gnus/gnus-group.el (gnus-group-completing-read): Only do the
        unibyte check once; make sure it applies to hash table keys as
        well.
      03ceee0e
    • Paul Eggert's avatar
      Make struct Lisp_Objfwd etc. objects read-only · 74b63d27
      Paul Eggert authored
      Initialize these objects statically, and make them constants.
      This is a bit safer and more efficient.
      * src/data.c (XBOOLFWD, XKBOARD_OBJFWD, XFIXNUMFWD, XOBJFWD):
      * src/lisp.h (XBUFFER_OBJFWD):
      Return a pointer-to-const instead of an unrestricted pointer.
      (lispfwd): fwdptr is now a pointer-to-const instead of an
      unrestricted pointer.  All uses changed.
      (SET_SYMBOL_FWD): Accept pointer-to-const instead of an
      unrestricted pointer.
      (DEFVAR_LISP, DEFVAR_LISP_NOPRO, DEFVAR_BOOL, DEFVAR_INT)
      (DEFVAR_KBOARD): Initialize static structures statically
      instead of dynamically, and make them const.
      * src/lread.c (defvar_int, defvar_bool, defvar_lisp_nopro)
      (defvar_lisp, defvar_kboard): Accept pointer-to-const instead
      of an unrestricted pointer; it’s now the caller’s
      responsibility to initialize the pointed-to storage.  No need
      for a separate address argument any more.  All callers
      changed.
      74b63d27
    • Paul Eggert's avatar
      Fix union Lisp_Fwd * alignment bug · 9287813d
      Paul Eggert authored
      It's not portable to cast (e.g.) struct Lisp_Objfwd * to union
      Lisp_Fwd * and then back again, because the compiler can then assume
      that the pointer is aligned for union Lisp_Fwd * when accessing
      the struct Lisp_Objfwd * components, and this assumption might
      be incorrect becase we don't force that alignment.
      * src/lisp.h (lispfwd): New type, replacing ...
      (union Lisp_Fwd): ... this type, which was removed.
      All uses changed.
      (SET_SYMBOL_FWD): 2nd arg is now void *, not lispfwd.
      All uses changed (casts no longer needed; they were
      not portable anyway).
      9287813d
    • Stefan Monnier's avatar
      * lisp/subr.el (setq-default): Define as a macro · 197fbfc7
      Stefan Monnier authored
      * lisp/emacs-lisp/bytecomp.el (byte-compile-setq-default): Delete.
      (byte-compile-set-default): Inline the part that it used.
      
      * lisp/emacs-lisp/edebug.el (setq-default): Remove the debug spec.
      
      * src/data.c (Fsetq_default): Delete.
      (syms_of_data): Don't register.
      197fbfc7
    • Eli Zaretskii's avatar
      Fix a typo in xterm.c and w32term.c · 20ef15fb
      Eli Zaretskii authored
      * src/xterm.c (x_window_to_scroll_bar):
      * src/w32term.c (x_window_to_scroll_bar): Fix a typo.
      20ef15fb
    • Glenn Morris's avatar
      ; Auto-commit of loaddefs files. · d5fdccca
      Glenn Morris authored
      d5fdccca
    • Paul Eggert's avatar
      Use update-game-score more often with Tetris · 1827197e
      Paul Eggert authored
      * lisp/play/gamegrid.el (gamegrid-add-score-with-update-game-score):
      Go back to previous way of deciding whether to invoke
      update-game-score, except do not try to invoke it if file-modes
      fails on it (Bug#35056).
      1827197e
  3. 31 Mar, 2019 7 commits
    • Basil L. Contovounesios's avatar
      Do not set indent-line-function in text-mode · 63471c83
      Basil L. Contovounesios authored
      * lisp/textmodes/text-mode.el (text-mode): Do not reset
      indent-line-function to its global default value of indent-relative.
      * doc/lispref/modes.texi (Example Major Modes):
      * etc/NEWS: Document change accordingly.
      63471c83
    • Basil L. Contovounesios's avatar
      Do not set indent-line-function in text-mode · 2e3deb09
      Basil L. Contovounesios authored
      For discussion, see thread starting at:
      https://lists.gnu.org/archive/html/emacs-devel/2019-03/msg01012.html
      * lisp/textmodes/text-mode.el (text-mode): Do not reset
      indent-line-function to its global default value of indent-relative.
      * doc/lispref/modes.texi (Example Major Modes):
      * etc/NEWS: Document change accordingly.
      2e3deb09
    • Basil L. Contovounesios's avatar
      Use lexical-binding in text-mode.el · 4c9950d0
      Basil L. Contovounesios authored
      * lisp/textmodes/text-mode.el: Use lexical-binding.
      (text-mode, paragraph-indent-minor-mode, text-mode-hook-identify):
      Use setq-local.
      (toggle-text-mode-auto-fill): Quote function symbols as such.
      (center-line): Minor simplification.
      * doc/lispref/modes.texi (Example Major Modes): Update code example
      for these changes to text-mode.
      4c9950d0
    • Alan Third's avatar
      Use the correct filename for dump file in NS · 07d7852b
      Alan Third authored
      * nextstep/Makefile.in (all):
      (${ns_appbindir}/Emacs.pdmp):
      (links): Use mixed case 'Emacs.pdmp' to match the executable name.
      07d7852b
    • Basil L. Contovounesios's avatar
      Fix recently extended delete-indentation behavior · 0cd250e9
      Basil L. Contovounesios authored
      * doc/lispref/text.texi (User-Level Deletion): Document new optional
      arguments of delete-indentation.
      
      * lisp/simple.el (delete-indentation): Do not barf if called
      interactively when region is inactive. (bug#35021)
      Do not skip blank lines. (bug#35036)
      Consistently deactivate mark even when no text was changed.
      Handle active region spanning a single line.
      
      * test/lisp/simple-tests.el (simple-test--buffer-substrings):
      New convenience function.
      (simple-test--dummy-buffer, simple-test--transpositions): Use it.
      (simple-delete-indentation-no-region)
      (simple-delete-indentation-inactive-region): Update commentary.
      Call delete-indentation interactively when testing for behavior with
      inactive region and region is not explicitly defined.
      (simple-delete-indentation-blank-line)
      (simple-delete-indentation-boundaries)
      (simple-delete-indentation-region)
      (simple-delete-indentation-prefix): New tests.
      0cd250e9
    • Eric Abrahamsen's avatar
      Check gnus-newsgroup-dependencies is hash table in gnus-id-to-thread · 99be0aba
      Eric Abrahamsen authored
      * lisp/gnus/gnus-sum.el (gnus-id-to-thread): If dependencies haven't
        been initialized yet, don't blow up. Mimicks previous (non hasht
        table) behavior.
      99be0aba
    • Mattias Engdegård's avatar
      Fix typo in regexp-opt example code · 6d7e18e8
      Mattias Engdegård authored
      * doc/lispref/searching.texi (Regexp Functions):
      Fix typo in example code (Bug#34596).
      6d7e18e8
  4. 30 Mar, 2019 5 commits
    • Alan Mackenzie's avatar
      Allow a CC Mode derived mode to have strings delimited by single quotes. · b619777d
      Alan Mackenzie authored
      Also fix the bug where the delimiters of '\033', etc. got the error face.
      
      * lisp/progmodes/cc-langs.el (c-single-quotes-quote-strings): Enhance the docr
      string.
      (c-string-delims): Change doc string to doc comment.
      
      * listp/progmodes/cc-mode.el (c-before-change-check-unbalanced-strings): In
      searches and comparisons, take account of the string delimiters possibly
      being '.  Fix argument in call of c-before-change-check-unbalanced-strings.
      (c-parse-quotes-before-change, c-parse-quotes-after-change): Bind
      case-fold-search to nil.  Analyze escape constructs inside character constants
      more accurately, in particular accepting as valid more than one character
      after /[0-7], /x, /u, and /U.  Amend calculations to account for this extra
      length.
      b619777d
    • Eli Zaretskii's avatar
      Fix a thinko in a recent commit · dd7d83e1
      Eli Zaretskii authored
      * src/buffer.c (Fkill_buffer): Fix last change.  (Bug#31138)
      Reported by Mattias Engdegård <mattiase@acm.org>.
      dd7d83e1
    • Mattias Engdegård's avatar
      Release regexp before signalling overflow error · f2c14b2f
      Mattias Engdegård authored
      * src/search.c (looking_at_1, search_buffer_re): Unfreeze the regexp
      buffer before signalling a matcher overflow, since the error
      processing may require quite some regexp use as well (Bug#34910).
      f2c14b2f
    • Mattias Engdegård's avatar
      Fix spurious regexp reentrancy error · 75ec1b19
      Mattias Engdegård authored
      * src/search.c (compile_pattern): Don't give up if the last regexp
      cache entry is busy.  Instead, use the last (least recently used)
      non-busy entry, and only signal a reentrancy error if there is no free
      entry at all (Bug#34910).
      75ec1b19
    • Eli Zaretskii's avatar
      Don't run buffer-related hooks in " *code conversion work*" buffers · 9c0fa117
      Eli Zaretskii authored
      Note: portions of this change were mistakenly pushed as part
      of an unrelated commit a35a1f6a.
      
      * src/buffer.c (Fget_buffer_create): Set inhibit_buffer_hooks
      non-zero for temporary buffers created by coding.c.  Don't run
      buffer-list-update-hook for such buffers.
      (Frename_buffer, Fkill_buffer, record_buffer)
      (Fbury_buffer_internal): Don't run hooks for buffers whose
      inhibit_buffer_hooks flag is set.
      * src/buffer.h (struct buffer): New member
      inhibit_buffer_hooks.
      * src/pdumper.c (dump_buffer): Dump the new field.  Update the
      hash value in HASH_buffer_XXX.
      * src/coding.c (make_conversion_work_buffer): Function deleted;
      code moved to code_conversion_save.
      (code_conversion_save): Insert code from
      make_conversion_work_buffer, but arrange for unwind-protecting
      the current buffer before switching to the work buffer.  This
      avoids leaving reused_workbuf_in_use set if user presses C-g
      during encoding/decoding.
      (Vcode_conversion_workbuf_name): Now external variable.
      * src/coding.h (Vcode_conversion_reused_workbuf): Declare.
      9c0fa117
  5. 29 Mar, 2019 3 commits
  6. 28 Mar, 2019 8 commits
  7. 27 Mar, 2019 2 commits